Skip to content

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented May 3, 2018

Fix #50415.

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2018
@michaelwoerister
Copy link
Member

Great catch, @kennytm! That was clearly using the same NodeId for two different nodes.

@bors r+

@bors
Copy link
Collaborator

bors commented May 3, 2018

📌 Commit 83c4505 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2018
kennytm added a commit to kennytm/rust that referenced this pull request May 3, 2018
…g-range-inclusive-from-closure, r=michaelwoerister

Fix ICE when using a..=b in a closure.

Fix rust-lang#50415.
bors added a commit that referenced this pull request May 3, 2018
Rollup of 12 pull requests

Successful merges:

 - #50302 (Add query search order check)
 - #50320 (Fix invalid path generation in rustdoc search)
 - #50349 (Rename "show type declaration" to "show declaration")
 - #50360 (Clarify wordings of the `unstable_name_collision` lint.)
 - #50365 (Use two vectors in nearest_common_ancestor.)
 - #50393 (Allow unaligned reads in constants)
 - #50401 (Revert "Implement FromStr for PathBuf")
 - #50406 (Forbid constructing empty identifiers from concat_idents)
 - #50407 (Always inline simple BytePos and CharPos methods.)
 - #50416 (check if the token is a lifetime before parsing)
 - #50417 (Update Cargo)
 - #50421 (Fix ICE when using a..=b in a closure.)

Failed merges:
@bors bors merged commit 83c4505 into rust-lang:master May 3, 2018
@kennytm kennytm deleted the fix-50415-ice-when-returning-range-inclusive-from-closure branch May 3, 2018 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants